Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Permissions #782

Merged
merged 6 commits into from
Feb 25, 2025
Merged

fix(ci): Permissions #782

merged 6 commits into from
Feb 25, 2025

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Feb 24, 2025

Please provide the issue number

Issue number: #762

Summary

Changes

Please provide a summary of what's being changed

Adds contents: read to permissions list in two workflows.

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from amirkaws February 24, 2025 13:20
@boring-cyborg boring-cyborg bot added github-actions Changes in GitHub workflows internal Maintenance changes labels Feb 24, 2025
@auto-assign auto-assign bot requested review from hjgraca and sliedig February 24, 2025 13:20
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2025
hjgraca
hjgraca previously requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@hjgraca hjgraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing to build error: Ensure 3rd party workflows have SHA pinned

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2025
@sthulb sthulb merged commit c185ed1 into develop Feb 25, 2025
2 of 4 checks passed
@sthulb sthulb deleted the fix/ci branch February 25, 2025 13:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot added the bug Unexpected, reproducible and unintended software behaviour label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrodamascena leandrodamascena leandrodamascena left review comments

@hjgraca hjgraca hjgraca left review comments

@amirkaws amirkaws Awaiting requested review from amirkaws

@sliedig sliedig Awaiting requested review from sliedig

Assignees
No one assigned
Labels
bug Unexpected, reproducible and unintended software behaviour github-actions Changes in GitHub workflows internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sthulb @hjgraca @leandrodamascena