-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Metrics AspNetCore support #775
chore: Metrics AspNetCore support #775
Conversation
…ing and middleware support for aspnetcore. Docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #775 +/- ##
===========================================
+ Coverage 73.82% 73.95% +0.13%
===========================================
Files 205 210 +5
Lines 8324 8378 +54
Branches 901 904 +3
===========================================
+ Hits 6145 6196 +51
Misses 1884 1884
- Partials 295 298 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…r .NET 6.0 and 8.0
…a-dotnet into feature/metrics-aspnetcore
…ca/powertools-lambda-dotnet into feature/metrics-aspnetcore
… and improving syntax
… default dimensions
…ations and enhance cold start metric capturing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUPER NICE WORK @hjgraca! I just left some small comments before you merge it!
…m dimensions limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED!!!
|
Issue number: #773
Summary
Changes
This pull request introduces a new library for capturing and publishing custom metrics from AWS Lambda functions using ASP.NET Core. The key changes include adding project references, creating new classes for metrics handling, and updating documentation.
New Library
AWS.Lambda.Powertools.Metrics.AspNetCore
New Library Introduction:
AWS.Lambda.Powertools.Metrics.AspNetCore
: Added new project for ASP.NET Core metrics handling.AWS.Lambda.Powertools.Metrics.AspNetCore.Tests
: Added new project for testing the ASP.NET Core metrics library.Metrics Handling:
Http/MetricsEndpointExtensions.cs
: Added extension methods for route handlers to include metrics filters.Http/MetricsFilter.cs
: Created a filter class to capture and record metrics for HTTP endpoints.Http/MetricsHelper.cs
: Introduced a helper class to capture cold start metrics and record them.Http/MetricsMiddlewareExtensions.cs
: Added middleware extension methods to capture metrics for HTTP requests.Documentation:
README.md
: Provided detailed usage instructions and examples for the new ASP.NET Core metrics library.Solution Configuration:
AWS.Lambda.Powertools.sln
: Updated the solution file to include the new ASP.NET Core metrics projects and their configurations. [1] [2]User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.