Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Metrics AspNetCore support #775

Merged
merged 27 commits into from
Feb 27, 2025

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 21, 2025

Please provide the issue number

Issue number: #773

Summary

Changes

This pull request introduces a new library for capturing and publishing custom metrics from AWS Lambda functions using ASP.NET Core. The key changes include adding project references, creating new classes for metrics handling, and updating documentation.

New Library AWS.Lambda.Powertools.Metrics.AspNetCore

New Library Introduction:

Metrics Handling:

Documentation:

  • README.md: Provided detailed usage instructions and examples for the new ASP.NET Core metrics library.

Solution Configuration:

User experience

Image

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

…ing and middleware support for aspnetcore.

Docs
@hjgraca hjgraca self-assigned this Feb 21, 2025
@auto-assign auto-assign bot requested review from amirkaws and sliedig February 21, 2025 19:13
@boring-cyborg boring-cyborg bot added area/metrics Core metrics utility documentation Improvements or additions to documentation tests labels Feb 21, 2025
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 21, 2025
@hjgraca hjgraca linked an issue Feb 21, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 86.53846% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.95%. Comparing base (b0d8807) to head (367d990).
Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
...owertools.Metrics.AspNetCore/Http/MetricsFilter.cs 62.50% 6 Missing ⚠️
...aries/src/AWS.Lambda.Powertools.Metrics/Metrics.cs 86.84% 2 Missing and 3 partials ⚠️
...WS.Lambda.Powertools.Common/Core/ConsoleWrapper.cs 75.00% 1 Missing ⚠️
...rtools.Metrics.AspNetCore/Http/ColdStartTracker.cs 95.83% 0 Missing and 1 partial ⚠️
...ambda.Powertools.Metrics/Internal/MetricsAspect.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #775      +/-   ##
===========================================
+ Coverage    73.82%   73.95%   +0.13%     
===========================================
  Files          205      210       +5     
  Lines         8324     8378      +54     
  Branches       901      904       +3     
===========================================
+ Hits          6145     6196      +51     
  Misses        1884     1884              
- Partials       295      298       +3     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boring-cyborg boring-cyborg bot added github-actions Changes in GitHub workflows internal Maintenance changes labels Feb 22, 2025
@boring-cyborg boring-cyborg bot added the area/common Core Powertools utility label Feb 26, 2025
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPER NICE WORK @hjgraca! I just left some small comments before you merge it!

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!!!

Copy link

@hjgraca hjgraca merged commit 475ade3 into aws-powertools:develop Feb 27, 2025
10 checks passed
@hjgraca hjgraca deleted the feature/metrics-aspnetcore branch February 27, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/common Core Powertools utility area/metrics Core metrics utility documentation Improvements or additions to documentation github-actions Changes in GitHub workflows internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Metrics support for AspNetCore
2 participants