chore: Add Aot e2e tests for x86 #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
github-actions
pull-request-size
bot
added
the
size/L
hjgraca
changed the title
|
leandrodamascena
approved these changes
Jan 16, 2025
dreamorosi
reviewed
Jan 16, 2025
| dotnet-version: '8.x' | ||
|
|
||
| - name: Install CDK | ||
| run: npm install -g aws-cdk |
There was a problem hiding this comment.
I don't think this is a good idea.
From a functional perspective, the CLI will go out of sync with the assembly version you have in the tests, and eventually fail.
From a security perspective, you're not pinning the dependency to a specific version/hash in a lock file, which opens up to supply chain security issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #683
Summary
Changes
Add E2E tests for AOT x86 only. Currently we do not have support for ARM runners
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.