Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add e2e tests #692

Merged
merged 23 commits into from
Jan 14, 2025
Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 14, 2025

Please provide the issue number

Issue number: #683

Summary

Changes

This pull request includes significant changes to the end-to-end (E2E) testing infrastructure and various related files. The changes primarily focus on simplifying and consolidating the deployment and destruction of AWS CDK stacks, updating test configurations, and improving the overall code structure.

Changes to E2E Testing Infrastructure:

  • Removed the separate workflows for deploying and destroying E2E infrastructure (.github/workflows/e2e-infra-deploy.yml, .github/workflows/e2e-infra-destroy.yml) and integrated these steps into the main E2E testing workflow (.github/workflows/e2e-tests.yml). [1] [2] [3] [4] [5]

Updates to Test Configurations:

  • Added installation of AWS Lambda .NET CLI Tools and setup of QEMU in the E2E tests workflow to support multi-architecture testing.
  • Adjusted test configurations to exclude ARM AOT .NET 8 metrics and tracing tests temporarily. [1] [2]

Code Structure Improvements:

  • Refactored the CoreAotStack class to use a custom AotStackProps for better handling of architecture-specific configurations. [1] [2]
  • Added a timeout configuration to the FunctionConstruct classes in both infra and infra-aot directories. [1] [2]

Miscellaneous Changes:

  • Removed redundant headers from the payload and test assertions in the FunctionTest class. [1] [2]
  • Corrected namespace usage in the Function.cs file.

These changes aim to streamline the E2E testing process, enhance the maintainability of the codebase, and ensure better support for various runtime environments.

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig January 14, 2025 13:28
@boring-cyborg boring-cyborg bot added github-actions Changes in GitHub workflows internal Maintenance changes tests labels Jan 14, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (57ab34e) to head (37bfb36).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #692      +/-   ##
===========================================
+ Coverage    73.32%   73.34%   +0.02%     
===========================================
  Files          200      200              
  Lines         8112     8112              
  Branches       872      872              
===========================================
+ Hits          5948     5950       +2     
+ Misses        1875     1874       -1     
+ Partials       289      288       -1     
Flag Coverage Δ
unittests 73.34% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjgraca hjgraca merged commit 17d9435 into aws-powertools:develop Jan 14, 2025
10 checks passed
@hjgraca hjgraca deleted the feature/e2etests branch January 14, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Changes in GitHub workflows internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants