Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): load self hosted mermaid.js #635

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

dreamorosi
Copy link
Contributor

Please provide the issue number

Issue number: closes #634

Summary

This PR updates the mkdocs.yml file for the documentation so that it loads the mermaid.js script from our own CDN.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Aug 26, 2024
@auto-assign auto-assign bot requested review from amirkaws, hjgraca and sliedig August 26, 2024 10:13
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2024
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 26, 2024
@github-actions github-actions bot added the internal Maintenance changes label Aug 26, 2024
Copy link

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (871f18b) to head (8088937).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #635      +/-   ##
===========================================
- Coverage    72.73%   72.45%   -0.28%     
===========================================
  Files          190      190              
  Lines         7886     7886              
  Branches       850      850              
===========================================
- Hits          5736     5714      -22     
- Misses        1860     1878      +18     
- Partials       290      294       +4     
Flag Coverage Δ
unittests 72.45% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena self-requested a review August 26, 2024 10:22
@dreamorosi dreamorosi merged commit 175d33b into develop Aug 26, 2024
8 of 9 checks passed
@dreamorosi dreamorosi deleted the chore/docs_script_self branch August 26, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: update docs to use self-hosted mermaid.js script
2 participants