-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Logging AOT Support #628
Merged
hjgraca
merged 38 commits into
aws-powertools:develop
from
hjgraca:aot(logging)-support-logging
Sep 23, 2024
Merged
chore: Logging AOT Support #628
hjgraca
merged 38 commits into
aws-powertools:develop
from
hjgraca:aot(logging)-support-logging
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fic paths. New helper method to convert anonymous types to dictionary, use for source generation .NET 8
…a-dotnet into aot(logging)-support-logging
|
… refactor. fix bug when using logger with no decorator. more tests and new PowertoolsSourceGeneratorSerializer.cs
hjgraca
commented
Sep 20, 2024
hjgraca
commented
Sep 20, 2024
libraries/src/AWS.Lambda.Powertools.Logging/Serializers/PowertoolsLoggingSerializer.cs
Show resolved
Hide resolved
amirkaws
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…date Logging version for release
|
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aot
area/common
Core Powertools utility
area/logging
Core logging utility
documentation
Improvements or additions to documentation
internal
Maintenance changes
pending-release
Fix or implementation already in dev waiting to be released
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #212
Summary
Changes
User experience
With the new PowertoolsSourceGeneratorSerializer, we can combine Powertools SerlializationContext with the customer Serialization context, this enables Powertools to serialize customer only types, this is useful for LogEvent feature.
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.