-
Notifications
You must be signed in to change notification settings - Fork 26
chore: Fix metrics lambda context and storage resolution #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix metrics lambda context and storage resolution #613
Conversation
…ialization due to reflection (AOT). Create new converter and use the default one on strings only.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #613 +/- ##
===========================================
- Coverage 72.58% 72.43% -0.15%
===========================================
Files 190 190
Lines 7900 7897 -3
Branches 850 852 +2
===========================================
- Hits 5734 5720 -14
- Misses 1876 1889 +13
+ Partials 290 288 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure why is failing but codecov is green when going to the details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue number: #612
Summary
WIth the new AOT release there was a problem at runtime with the serializaton of LambdaContext when capturing cold starts, the funcionname was not being set
There is also a issue with StorageResolution serialization not serializing to
int
instead is serializing the string"High"
Changes
MetricResolutionJsonConverter
to serialize StorageResolution correctlyStringEnumConverter
forMetricsUnit
and add the defaultJsonStringEnumConverter
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.