Skip to content

chore: Update build pipeline #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2024
Merged

chore: Update build pipeline #584

merged 4 commits into from
May 9, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented May 8, 2024

Update setup dotnet and codecov actions

Please provide the issue number

Issue number: #583

Summary

Update build pipeline actions for setupdotnet and codecov

Changes

  • actions/setup-dotnet to 4.0.0
  • codecov/codecov-action to 4.3.1

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Update setup dotnet and codecov actions

Signed-off-by: Henrique Graca <[email protected]>
@auto-assign auto-assign bot requested a review from amirkaws May 8, 2024 10:25
@boring-cyborg boring-cyborg bot added the github-actions Changes in GitHub workflows label May 8, 2024
@auto-assign auto-assign bot requested a review from sliedig May 8, 2024 10:25
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label May 8, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2024
@hjgraca hjgraca linked an issue May 8, 2024 that may be closed by this pull request
1 task
hjgraca added 2 commits May 8, 2024 11:50
Signed-off-by: Henrique Graca <[email protected]>
Signed-off-by: Henrique Graca <[email protected]>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2024
Signed-off-by: Henrique Graca <[email protected]>
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.91%. Comparing base (ff53f97) to head (5f2078d).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #584      +/-   ##
===========================================
- Coverage    72.95%   72.91%   -0.05%     
===========================================
  Files          109      109              
  Lines         4489     4489              
  Branches       455      455              
===========================================
- Hits          3275     3273       -2     
- Misses        1085     1086       +1     
- Partials       129      130       +1     
Flag Coverage Δ
unittests 72.91% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit 5bc87a0 into develop May 9, 2024
9 of 10 checks passed
@hjgraca hjgraca deleted the hjgraca-build-pipeline branch May 9, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Changes in GitHub workflows internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Update build pipeline action versions
2 participants