Skip to content

feat: New log level #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Nov 16, 2023

Please provide the issue number

Issue number: #515

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig November 16, 2023 15:05
@boring-cyborg boring-cyborg bot added area/common Core Powertools utility area/logging Core logging utility documentation Improvements or additions to documentation tests labels Nov 16, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 16, 2023
@github-actions github-actions bot added the feature New features or minor changes label Nov 16, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (654de19) 74.41% compared to head (fcb180c) 72.18%.
Report is 19 commits behind head on develop.

Files Patch % Lines
...da.Powertools.Logging/Internal/PowertoolsLogger.cs 88.00% 1 Missing and 2 partials ⚠️
...tools.Logging/Internal/PowertoolsConfigurations.cs 93.75% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #516      +/-   ##
===========================================
- Coverage    74.41%   72.18%   -2.23%     
===========================================
  Files          101      101              
  Lines         4057     4106      +49     
  Branches         0      417     +417     
===========================================
- Hits          3019     2964      -55     
+ Misses        1038     1025      -13     
- Partials         0      117     +117     
Flag Coverage Δ
unittests 72.18% <92.15%> (-2.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit 53bb027 into aws-powertools:develop Nov 16, 2023
@hjgraca hjgraca deleted the lambda-log-level branch November 16, 2023 15:14
@hjgraca hjgraca linked an issue Nov 16, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/common Core Powertools utility area/logging Core logging utility documentation Improvements or additions to documentation feature New features or minor changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add support for new Log Level
3 participants