-
Notifications
You must be signed in to change notification settings - Fork 26
fix: Stack trace lost when exception is thrown the when using decorator #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Stack trace lost when exception is thrown the when using decorator #357
Conversation
…DispatchInfo is used to preserve the stack trace after an Exception is thrown, allows catching that exception, not throwing it immediately (as part of a catch), and to raise such exception on a later point in the future. Add tests
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #357 +/- ##
===========================================
+ Coverage 69.52% 71.48% +1.96%
===========================================
Files 79 79
Lines 3491 3496 +5
===========================================
+ Hits 2427 2499 +72
+ Misses 1064 997 -67
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
libraries/tests/AWS.Lambda.Powertools.Logging.Tests/AWS.Lambda.Powertools.Logging.Tests.csproj
Outdated
Show resolved
Hide resolved
libraries/tests/AWS.Lambda.Powertools.Metrics.Tests/AWS.Lambda.Powertools.Metrics.Tests.csproj
Outdated
Show resolved
Hide resolved
libraries/tests/AWS.Lambda.Powertools.Tracing.Tests/AWS.Lambda.Powertools.Tracing.Tests.csproj
Outdated
Show resolved
Hide resolved
# Conflicts: # libraries/tests/AWS.Lambda.Powertools.Logging.Tests/AWS.Lambda.Powertools.Logging.Tests.csproj # libraries/tests/AWS.Lambda.Powertools.Metrics.Tests/AWS.Lambda.Powertools.Metrics.Tests.csproj # libraries/tests/AWS.Lambda.Powertools.Metrics.Tests/MetricsTests.cs # libraries/tests/AWS.Lambda.Powertools.Tracing.Tests/AWS.Lambda.Powertools.Tracing.Tests.csproj # libraries/tests/AWS.Lambda.Powertools.Tracing.Tests/TracingAttributeTest.cs
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue number: #353
Summary
When an exception is thrown inside a method which that is decorated with utilities the user should see the full stack trace for that exception.
Currently the stack traces is lost.
Changes
MethodAspectHandler interface update so that OnException does not return.
On each utility that implements MethodApstectHandler, we capture the exception with
ExceptionDispatchInfo
.[ExceptionDispatchInfo](https://learn.microsoft.com/en-us/dotnet/api/system.runtime.exceptionservices.exceptiondispatchinfo?view=net-7.0&redirectedfrom=MSDN)
is used to preserve the stack trace after an Exception is thrown, allowing you to catch that exception, not throwing it immediately (as part of a catch), and to raise such exception on a later point in the future.Docs on how to Capture exceptions and rethrow later
Added tests that validate the stack trace is being sent to the client
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.