Skip to content

[Dotnet] Fix sig v4 test #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Dotnet] Fix sig v4 test #403

wants to merge 4 commits into from

Conversation

Jeel-mehta
Copy link
Contributor

Issue description:
The ADOT Dotnet Sigv4 test was failing because the Xray backend team changed the value of the dimensions of Metric validator.

Description of changes:
The dimension values were updated to be consistent with the changes from the backend.

Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/14938571788/job/41971542923

Rollback procedure:

<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>

Ensure you've run the following tests on your changes and include the link below:

To do so, create a test.yml file with name: Test and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.

  • Run Java EKS on e2e-playground in us-east-1 and eu-central-2
  • Run Python EKS on e2e-playground in us-east-1 and eu-central-2
  • Run metric limiter on EKS cluster e2e-playground in us-east-1 and eu-central-2
  • Run EC2 tests in all regions
  • Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Jeel Mehta added 3 commits May 9, 2025 14:22
@Jeel-mehta Jeel-mehta force-pushed the Dotnet_SigV4_Test branch from 710e41c to fecc1d8 Compare May 9, 2025 22:24
@Jeel-mehta Jeel-mehta requested review from harrryr and liustve May 9, 2025 22:26
@Jeel-mehta Jeel-mehta marked this pull request as ready for review May 9, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants