Skip to content

Add equal vars for Rules to cnf building #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 24, 2024

Issue #, if available:
fix #3710

Description of changes:

  • Add equal vars for Rules to cnf building

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (9782e80) to head (5a54700).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3714      +/-   ##
==========================================
- Coverage   93.71%   93.69%   -0.03%     
==========================================
  Files         362      362              
  Lines       12345    12346       +1     
  Branches     2635     2635              
==========================================
- Hits        11569    11567       -2     
- Misses        429      430       +1     
- Partials      347      349       +2     
Flag Coverage Δ
unittests 93.63% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit c1f8b15 into aws-cloudformation:main Sep 24, 2024
20 of 21 checks passed
@kddejong kddejong deleted the fix/issue/3710 branch September 24, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Rules support Condition, which is not a rule-specific intrinsic function
1 participant