Skip to content

Update E3054 to not alert on awsvpc #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #3592

Description of changes:

  • Update E3054 to not alert on awsvpc

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (5b268db) to head (31a7029).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3593      +/-   ##
==========================================
- Coverage   93.60%   93.59%   -0.01%     
==========================================
  Files         353      353              
  Lines       11928    11931       +3     
  Branches     2545     2547       +2     
==========================================
+ Hits        11165    11167       +2     
  Misses        426      426              
- Partials      337      338       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 3409497 into aws-cloudformation:main Aug 13, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3592 branch August 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.10.0: Possible false-positive for E3054: 'RequiresCompatibilities' is a required property
1 participant