Skip to content

Update W3663 to skip validation when Sub #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jul 31, 2024

Issue #, if available:
fix #3547

Description of changes:

  • Update W3663 to skip validation when Sub
  • Make sure to return rule E3673 in validation error

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (e17d66e) to head (1268bc2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3548      +/-   ##
==========================================
- Coverage   93.63%   93.62%   -0.02%     
==========================================
  Files         348      348              
  Lines       11691    11684       -7     
  Branches     2473     2470       -3     
==========================================
- Hits        10947    10939       -8     
  Misses        415      415              
- Partials      329      330       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 2153ec2 into aws-cloudformation:main Jul 31, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3547 branch July 31, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E3003 on missing SourceAccount when SourceArn is specified using !Sub
1 participant