Skip to content

feat(auth): remove support for token query param #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Apr 25, 2025

Issue #, if available:

Description of changes:

Removing support for tokenQueryParam.

As per OIDC / OAuth specification, token endpoint must not allow any query parameters. So, the SDK needs to be updated to not allow any query parameters for Token endpoint.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested review from awsmobilesdk and a team as code owners April 25, 2025 16:43
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Active
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest April 25, 2025 16:43 — with GitHub Actions Inactive
Copy link
Member

@thisisabhash thisisabhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add details about the decision to remove support for token query params in the description?

@harsh62 harsh62 merged commit d3c1285 into main May 5, 2025
107 of 108 checks passed
@harsh62 harsh62 deleted the token-query-param branch May 5, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants