Skip to content

fix(AWSCore): call response interceptors in HTTP response handlers #5495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix(AWSCore): call response interceptors in HTTP response handlers #5495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions AWSCore/Networking/AWSURLSessionManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,13 @@ - (void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)sessionTask
if (!delegate.error
&& [sessionTask.response isKindOfClass:[NSHTTPURLResponse class]]) {
NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)sessionTask.response;

for(id<AWSNetworkingHTTPResponseInterceptor>interceptor in delegate.request.responseInterceptors) {
[interceptor interceptResponse:httpResponse
data:nil
originalRequest:sessionTask.originalRequest
currentRequest:sessionTask.currentRequest];
}

if (delegate.shouldWriteToFile) {
NSError *error = nil;
Expand Down Expand Up @@ -351,6 +358,14 @@ - (void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)sessionTask
if (delegate.error
&& ([sessionTask.response isKindOfClass:[NSHTTPURLResponse class]] || sessionTask.response == nil)
&& delegate.request.retryHandler) {

for(id<AWSNetworkingHTTPResponseInterceptor>interceptor in delegate.request.responseInterceptors) {
[interceptor interceptResponse:(NSHTTPURLResponse *)sessionTask.response
data:nil
originalRequest:sessionTask.originalRequest
currentRequest:sessionTask.currentRequest];
}

AWSNetworkingRetryType retryType = [delegate.request.retryHandler shouldRetry:delegate.currentRetryCount
originalRequest:delegate.request
response:(NSHTTPURLResponse *)sessionTask.response
Expand Down
Loading