Skip to content

fix(AWSCore): Fixing a name collision with CocoaLumberjack #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

sebaland
Copy link
Contributor

@sebaland sebaland commented Jun 3, 2024

Issue #, if available:

Description of changes:
This PR fixes the name collision on the doesAppRunInBackground function between CocoaLumberjack and our internal fork.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from awsmobilesdk and a team as code owners June 3, 2024 20:50
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:50 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest June 3, 2024 20:51 — with GitHub Actions Inactive
@sebaland sebaland merged commit bd6ea31 into main Jun 4, 2024
67 checks passed
@sebaland sebaland deleted the ruisebas/fixing-cocoalumberjack-conflict branch June 4, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants