Skip to content

fix(Predictions): Fix Liveness InvalidSignatureException #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

tylerjroach
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

We send video and client events over the liveness websocket. Video events and client events are sent from different threads. If a video and client event are sent at identical time, prior signatures may get mixed up, causing an invalid signature event. This approach uses a coroutine channel queue to ensure outbound websocket events are processed 1 at a time.

How did you test these changes?

Manual testing

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner March 7, 2024 22:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 7.81250% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 42.92%. Comparing base (956ba11) to head (1b677a5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
- Coverage   42.92%   42.92%   -0.01%     
==========================================
  Files         905      905              
  Lines       29115    29127      +12     
  Branches     4144     4144              
==========================================
+ Hits        12497    12502       +5     
- Misses      15261    15269       +8     
+ Partials     1357     1356       -1     

@tylerjroach tylerjroach merged commit f64361a into main Mar 11, 2024
@tylerjroach tylerjroach deleted the tjroach/fix-invalid-signature-liveness branch March 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants