Skip to content

chore: Fix rollback workflow file #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Fixes a couple of issues discovered with the rollback workflow

How did you test these changes?

  • Ran the workflow in a fork and verified it behaved as desired

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner February 5, 2024 19:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15a4523) 42.67% compared to head (239c35c) 42.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2705      +/-   ##
==========================================
- Coverage   42.67%   42.66%   -0.02%     
==========================================
  Files         905      905              
  Lines       29026    29026              
  Branches     4131     4131              
==========================================
- Hits        12386    12383       -3     
- Misses      15291    15295       +4     
+ Partials     1349     1348       -1     

@mattcreaser mattcreaser merged commit d229be4 into main Feb 6, 2024
@mattcreaser mattcreaser deleted the mattcreaser/rollback-fix branch February 6, 2024 14:33
mattcreaser added a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants