Skip to content

fix(geo): Fix Geo Plugin Auth injection #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

tylerjroach
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner February 5, 2024 18:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (d229be4) 42.65% compared to head (8f17c7d) 42.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage   42.65%   42.66%           
=======================================
  Files         905      905           
  Lines       29026    29032    +6     
  Branches     4131     4131           
=======================================
+ Hits        12382    12386    +4     
- Misses      15294    15297    +3     
+ Partials     1350     1349    -1     

mattcreaser
mattcreaser previously approved these changes Feb 5, 2024
ankpshah
ankpshah previously approved these changes Feb 5, 2024
@tylerjroach tylerjroach dismissed stale reviews from ankpshah and mattcreaser via 5db1cfa February 6, 2024 13:53
@tylerjroach tylerjroach enabled auto-merge (squash) February 6, 2024 15:56
@tylerjroach tylerjroach merged commit ebfde36 into main Feb 6, 2024
@tylerjroach tylerjroach deleted the tjroach/fix-geo-plugin-auth-injection branch February 6, 2024 16:55
mattcreaser added a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants