-
Notifications
You must be signed in to change notification settings - Fork 122
chore(all): Update to AWS Kotlin SDK v1.x stable #2695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
- Coverage 41.79% 41.79% -0.01%
==========================================
Files 903 903
Lines 28887 28891 +4
Branches 4113 4116 +3
==========================================
+ Hits 12074 12075 +1
- Misses 15488 15492 +4
+ Partials 1325 1324 -1 |
mattcreaser
previously approved these changes
Jan 31, 2024
…us implementation
…us implementation
…us implementation
mattcreaser
previously approved these changes
Feb 6, 2024
mattcreaser
approved these changes
Feb 6, 2024
tjleing
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Most changes were just import path differences. The biggest change otherwise is the AWSRequestSignerInterceptor for MapLibre. We were doing a lot of manual conversion from OkHttp requests <--> Smithy requests, which had a buggy/incomplete implementation.
Bugs
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.