Skip to content

chore(all): Update to AWS Kotlin SDK v1.x stable #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 6, 2024

Conversation

tylerjroach
Copy link
Member

@tylerjroach tylerjroach commented Jan 30, 2024

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

Most changes were just import path differences. The biggest change otherwise is the AWSRequestSignerInterceptor for MapLibre. We were doing a lot of manual conversion from OkHttp requests <--> Smithy requests, which had a buggy/incomplete implementation.

Bugs

  • Fragments weren't being added at the end (don't think maplibre uses them. Still not good to reconstruct partial urls)
  • If a url didn't have a subpath, the app would crash. I think were lucky all our maplibre calls are like .com/maps/v0
  • We end up duplicating query parameters because they were being added by passing the encodedPath (which included parameters). Then adding parameters manually right after.
  • There's also a lot to read and understand if whatever is being passed is encoded or not. I think parsing from string removes these concerns.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e6563dd) 41.79% compared to head (645ae53) 41.79%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2695      +/-   ##
==========================================
- Coverage   41.79%   41.79%   -0.01%     
==========================================
  Files         903      903              
  Lines       28887    28891       +4     
  Branches     4113     4116       +3     
==========================================
+ Hits        12074    12075       +1     
- Misses      15488    15492       +4     
+ Partials     1325     1324       -1     

mattcreaser
mattcreaser previously approved these changes Jan 31, 2024
@tylerjroach tylerjroach marked this pull request as ready for review February 2, 2024 14:46
@tylerjroach tylerjroach requested a review from a team as a code owner February 2, 2024 14:46
mattcreaser
mattcreaser previously approved these changes Feb 6, 2024
@tylerjroach tylerjroach enabled auto-merge (squash) February 6, 2024 20:28
@tylerjroach tylerjroach merged commit 4f3e54b into main Feb 6, 2024
@tylerjroach tylerjroach deleted the tjroach/bump-aws-kotlin-sdk-v1 branch February 6, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants