fix(datastore): Accept applicable data if errors are present when syncing #2278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcreaser
previously approved these changes
Feb 7, 2023
manueliglesias
force-pushed
the
manuelig/applicable-data
branch
from
45623fe to
7cfdc32
Compare
…sync query. - Do not prevent AppSyncClient from invoking onResponse if GraphQL errors are present in the response. - Make SyncProcessor's syncPage emit applicable data and log a warning if GraphQL errors were present too. - Make PaginatedResult filter out null items
…have data and errors
manueliglesias
force-pushed
the
manuelig/applicable-data
branch
from
7cfdc32 to
edaa8f7
Compare
div5yesh
previously approved these changes
Feb 28, 2023
Signed-off-by: Manuel Iglesias <[email protected]>
div5yesh
approved these changes
Mar 8, 2023
mattcreaser
approved these changes
Mar 15, 2023
gpanshu
pushed a commit
that referenced
this pull request
Apr 28, 2023
…cing (#2278) Signed-off-by: Manuel Iglesias <[email protected]> Co-authored-by: Divyesh Chitroda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
- Do not prevent AppSyncClient from invoking onResponse if GraphQL errors are present in the response.
- Make SyncProcessor's syncPage emit applicable data and log a warning if GraphQL errors were present too.
- Make PaginatedResult filter out null items
- Add Hub event for
nonApplicableDataReceived- Call errorHandler and send Hub event
How did you test these changes?
Manual and unit testing.
For manual testing, I went to my DynamoDB table and edited some items to remove required fields, then I cleared/started datastore to force base sync queries to happen. I verified that log messages were present in the logcat, that my custom errorHandler was invoked with the right exception and that the Hub events where emitted. I was able to query for all the applicable data and DataStore was still working as normal.
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.