Test that errorHandler and Hub events are called when sync responses have data and errors

Author: manueliglesias

aws-datastore/src/test/java/com/amplifyframework/datastore/syncengine/SyncProcessorTest.java

@@ -19,6 +19,7 @@
 
 import com.amplifyframework.AmplifyException;
 import com.amplifyframework.api.graphql.GraphQLRequest;
+import com.amplifyframework.api.graphql.GraphQLResponse;
 import com.amplifyframework.api.graphql.PaginatedResult;
 import com.amplifyframework.core.model.Model;
 import com.amplifyframework.core.model.ModelProvider;
@@ -54,6 +55,7 @@
 import com.amplifyframework.util.ForEach;
 import com.amplifyframework.util.Time;
 
+import com.google.common.collect.Lists;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -66,6 +68,7 @@
 import java.util.Iterator;
 import java.util.LinkedHashSet;
 import java.util.List;
+import java.util.Objects;
 import java.util.Random;
 import java.util.Set;
 import java.util.Timer;
@@ -86,6 +89,7 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.argThat;
 import static org.mockito.Mockito.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.spy;
@@ -609,6 +613,50 @@ public void userProvidedErrorCallbackInvokedOnFailure() throws DataStoreExceptio
         verify(this.errorHandler, times(1)).accept(any());
     }
 
+    /**
+     * Verify that the user-provided onError callback is invoked for every error if sync contains data and errors.
+     * Verify that Hub events are emitted once per page with non-applicable data
+     * @throws DataStoreException On failure to build GraphQLRequest for sync query.
+     */
+    @Test
+    public void userProvidedErrorCallbackInvokedOnNonApplicableData() throws DataStoreException {
+        // Arrange: mock data + errors when invoking hydrate on the mock object. Each response is a page in a paginated
+        // syncQuery
+        AppSyncMocking.sync(appSync)
+                .mockSuccessResponse(BlogOwner.class, null, "someToken",
+                        Lists.newArrayList(BLOGGER_JAMESON),
+                        Lists.newArrayList(
+                                new GraphQLResponse.Error("My Error 1", null, null, null),
+                                new GraphQLResponse.Error("My Error 2", null, null, null),
+                                new GraphQLResponse.Error("My Error 3", null, null, null)
+                        )
+                )
+                .mockSuccessResponse(BlogOwner.class, "someToken", null,
+                        Lists.newArrayList(BLOGGER_ISLA),
+                        Lists.newArrayList(
+                                new GraphQLResponse.Error("My Error 4", null, null, null),
+                                new GraphQLResponse.Error("My Error 5", null, null, null)
+                        )
+            );
+
+        // Collects nonApplicableDataReceived events.
+        HubAccumulator nonApplicableDataReceivedAccumulator =
+                createAccumulator(forEvent(DataStoreChannelEventName.NON_APPLICABLE_DATA_RECEIVED), 2);
+
+        // Act: Start the accumulators.
+        nonApplicableDataReceivedAccumulator.start();
+        // Act: call hydrate.
+        syncProcessor.hydrate().test().awaitDone(OP_TIMEOUT_MS, TimeUnit.MILLISECONDS).assertComplete();
+
+        // Assert: The error handler is called once for each GraphQL error
+        verify(this.errorHandler, times(5))
+                .accept(argThat(dataStoreException -> Objects.requireNonNull(dataStoreException.getMessage())
+                        .startsWith("Error received when syncing data:")));
+        // Assert: A single nonApplicableDataReceived event is emitted to the Hub for each syncQuery page
+        assertEquals(2, nonApplicableDataReceivedAccumulator
+                .await((int) OP_TIMEOUT_MS, TimeUnit.MILLISECONDS).size());
+    }
+
 
     /**
      * Verify that retry is called on appsync failure when syncRetry is set to true.