Skip to content

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 23, 2024
Merged

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #529

merged 8 commits into from
May 23, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 15, 2023

Issue #, if available:
From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

Description of changes:
This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx [email protected] -t v2-to-v3 index.js

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review November 15, 2023 07:42
@trivikr
Copy link
Contributor Author

trivikr commented Nov 15, 2023

cc recent committers @Lou1415926 @paragbhingre for review

@trivikr
Copy link
Contributor Author

trivikr commented Mar 11, 2024

AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025.

For more information, check blog post at https://a.co/cUPnyil

@amazreech
Copy link
Contributor

Hi @trivikr,

Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request. In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:

  1. Verify if PR follows semantic pull request conventions.

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve any merge conflicts on the PR

@trivikr
Copy link
Contributor Author

trivikr commented May 10, 2024

  • Verify if PR follows semantic pull request conventions.

It does

  • Please run npm run package command to update dist/ folder with latest dependencies.

Done.

  • Resolve any merge conflicts on the PR

Done.

@snago
Copy link

snago commented May 17, 2024

This should fix #551

@trivikr
Copy link
Contributor Author

trivikr commented May 20, 2024

@amazreech Is there anything else pending?

The asks were implemented in #529 (comment)

@omkhegde
Copy link
Contributor

Hi @trivikr,

Apologies for the delay. The changes lgtm, could you please resolve conflicts so we can merge this in?

Thanks.

@trivikr
Copy link
Contributor Author

trivikr commented May 23, 2024

could you please resolve conflicts so we can merge this in?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants