-
-
Notifications
You must be signed in to change notification settings - Fork 278
Fix: extend reload_records
to support grid view
#3780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: extend reload_records
to support grid view
#3780
Conversation
Code Climate has analyzed commit 9da6753 and detected 0 issues on this pull request. View more on Code Climate. |
view_type
to reload_records
methodreload_records
to support grid view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this @m7madmagdy
The view type should be inferred by Avo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @m7madmagdy, I noticed that you requested a review and then marked the PR as a draft.
Feel free to ping me once it's ready for a full review.
This refactor makes the view type accessible within the resource instead of being computed and stored on @index_params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @m7madmagdy, thanks for looking into this!
We're getting close to merging it. I've made this refactor that moves view_type
from @index_params
into the resource
object. This way, we don't need to pass view_type
through all the components like before. Also, for people using link_arguments
, there is no need to manually include view_type
as an argument anymore.
I also separated the reload row and reload grid functions. The grid item reload is much simpler and doesn't need to compute header fields or run other "heavy" logic.
Let me know what you think about these changes! Also, could you please add a test for this feature and a short paragraph in the docs mentioning that this feature is available for grid items starting from Avo 3.next_minor_version?
Hi @Paul-Bob This change looks good and much cleaner Thanks for the great refactor |
…gdy/avo into fix/reload-records-with-gridview
Description
Fixes #3718
Support
reload_records
with grid and map views after running an action.Checklist:
Screenshots & recording
Screencast.from.04-06-2025.09.20.49.PM.webm
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.