YARA-1550: Yara42 new math attributes #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metthal
reviewed
Feb 10, 2022
tests/cpp/parser_tests.cpp
Outdated
| @@ -3521,17 +3521,17 @@ import "math" | |||
| rule math_module | |||
| { | |||
| condition: | |||
| math.entropy("dummy") > 7 | |||
| math.to_number(math.entropy("dummy") > 7) == 1 | |||
There was a problem hiding this comment.
Should this be a brand new test instead of rewriting existing one?
There was a problem hiding this comment.
We do not have a test for each module attribute, so I personally think there is no trouble with testing more functions within one test. But I can create a new test if you would prefer it.
There was a problem hiding this comment.
Yeah, just put there more attributes.
metthal
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors the changes in yara introduced here:
VirusTotal/yara@87bc03d
VirusTotal/yara@0d5f2cd
VirusTotal/yara@2edd10c
Solves YARA-1550, YARA-1552 and YARA-1556.