Skip to content

Added iequals operator #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

Added iequals operator #182

merged 1 commit into from
Aug 12, 2021

Conversation

metthal
Copy link
Member

@metthal metthal commented Aug 5, 2021

No description provided.

@TadeasKucera TadeasKucera self-requested a review August 5, 2021 15:49
TadeasKucera
TadeasKucera approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@TadeasKucera TadeasKucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything seems to be alright and the python bindings were also added. The only thing that we should consider is to add some documentation, possibly to docs/rtd/creating_rulesets.rst. Do you want me to do it?

@metthal
Copy link
Member Author

metthal commented Aug 9, 2021

Added to the documentation.

@metthal metthal requested a review from TadeasKucera August 9, 2021 15:30
@metthal metthal merged commit 769df56 into master Aug 12, 2021
@metthal metthal deleted the iequals branch August 12, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TadeasKucera TadeasKucera Awaiting requested review from TadeasKucera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metthal @TadeasKucera