Add option to ignore stderr when executing commands #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augi
approved these changes
Feb 4, 2025
augi
force-pushed
the
feature/ignore_stderr
branch
from
711a6e8 to
8168b13
Compare
|
Looks like mypy has a problem with untyped |
augi
force-pushed
the
feature/ignore_stderr
branch
from
8168b13 to
1a38ee7
Compare
rabbull
force-pushed
the
feature/ignore_stderr
branch
from
1a38ee7 to
07f6c57
Compare
|
Thanks for checking this out. In last update, I annotated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new option,
ignore_stderr, to theexecutefunction as well as its wrapper methodDockerComposeExecutor.execute. The purpose of this addition is to address the issue mentioned in #114, where mergingstderrwithstdoutmade it difficult to distinguish between the two outputs. If this flag is set totrue, then the stderr outputs are ignored. To keep compatibility with previous versions, the output format of the functions remained unchanged, and this flag is set tofalsein default.It's a simple modification that fixed my own problem. I believe it being useful for anyone else encountered into the same problem with me, so I created this PR. Any feedback is welcome.