fix: stringify multiple tool responses is unnecessary #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit actually fixes the issue of multiple tool responses properly. The previous commit tried to stringify multiple responses but it was because the error was caused by the truncate library. We actually don't need to stringify them and this commit is fixing it.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with how multiple tool responses are logged by removing unnecessary stringification and refactoring the logging flow.
- Removed the import and usage of MessageContent and refactored log functions in MCP tools logging.
- Updated the tool.invoke patch to use the new logging functions (logMcpStart and logMcpEnd).
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ui/mcp-tools.ts | Removed redundant stringification logic and refactored logging start/end functions. |
| src/mcp/tools.ts | Updated tool.invoke patch to use the new logging functions for better logging flow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit actually fixes the issue of multiple tool responses properly.
The previous commit tried to stringify multiple responses but it was because the error was caused by the truncate library. We actually don't need to stringify them and this commit is fixing it.