Add support for OOB multi-factor authentication #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
commented
Jul 20, 2021
| @@ -403,14 +431,16 @@ public void onDatabaseAuthenticationRequest(@NonNull DatabaseLoginEvent event) { | |||
| AuthenticationAPIClient apiClient = options.getAuthenticationAPIClient(); | |||
| AuthenticationRequest request; | |||
| Map<String, String> parameters = new HashMap<>(options.getAuthenticationParameters()); | |||
| if (TextUtils.isEmpty(event.getMFAToken()) || TextUtils.isEmpty(event.getVerificationCode())) { | |||
| if (TextUtils.isEmpty(event.getMultifactorToken())) { | |||
There was a problem hiding this comment.
if there's no mfa_token, then log in normally
| if (!TextUtils.isEmpty(event.getVerificationCode())) { | ||
| parameters.put(KEY_VERIFICATION_CODE, event.getVerificationCode()); | ||
| } | ||
| } else if (MFA_CHALLENGE_TYPE_OOB.equals(lastDatabaseLogin.getMultifactorChallengeType())) { |
There was a problem hiding this comment.
if there's an mfa_token and also the challenge type is "oob", complete the verification using OOB
| } else { | ||
| request = apiClient.loginWithOTP(event.getMFAToken(), event.getVerificationCode()); | ||
| // otp multi-factor authentication | ||
| request = apiClient.loginWithOTP(event.getMultifactorToken(), event.getMultifactorOTP()); |
There was a problem hiding this comment.
otherwise, complete the verification using the OTP
| }); | ||
| if (error.isMultifactorRequired()) { | ||
| String mfaToken = (String) error.getValue(KEY_MFA_TOKEN); | ||
| requestMFAChallenge(mfaToken); |
There was a problem hiding this comment.
this logic was moved into a separate function requestMFAChallenge
| @@ -440,50 +521,6 @@ public void shouldCallOIDCDatabaseSignInWithCustomAudience() { | |||
| assertThat(reqParams, hasEntry("extra", "value")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldCallLegacyDatabaseSignInWithUsername() { | |||
There was a problem hiding this comment.
legacy tests for /oauth/ro MFA, removed
evansims
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Whenever an
mfa_requirederror is received from the server, and before showing the "MFA prompt" screen, the SDK will attempt to send an MFA challenge request to the registered OOB factor. If the user doesn't have any, the request will fail but the user will still be able to complete the authentication using the OTP generated from their favorite app.This PR also bumps the dependencies and commits the line-endings setting so every IDE will pick up.
References
See
SDK-2658.Videos showing the usage
MFA with SMS (OOB)
MFA-SMS-Success.mp4
MFA with OTP (fallback, always available)
MFA-OTP.mp4
Testing
Some tests regarding legacy use cases, those related to
/oauth/roMFA, were removed. Functionality is unaffected.This change adds unit test coverage
This change adds integration/UI test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors
The correct base branch is being used