Simplify library set up by declaring activities internally #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
previously approved these changes
Apr 29, 2021
|
@stevehobbsdev had to fix the tests! ready to review again |
lbalmaceda
commented
Apr 29, 2021
| <category android:name="android.intent.category.BROWSABLE" /> | ||
|
|
||
| <data | ||
| android:host="domain" |
There was a problem hiding this comment.
This test-scoped file was required to override the intent filter declaration with hardcoded values instead of the dynamically obtained ones (manifest placeholders), otherwise, it wouldn't even compile. I've found a way to set these for the test scope now through the build.gradle file and this manifest file is no longer required.
stevehobbsdev
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Before this PR, when a developer wanted to use this library, they would need to declare the Lock activities in the
AndroidManifest.xmlfile.Following what the SDK does, this PR will declare both Classic and Passwordless lock required activities, which will be merged in the final
AndroidManifest.xmlfile. This also applies to the "Internet" permission.This change effectively reduces the changes required to use the library, removing the need to modify the manifest file.
This is not a breaking change, but developers are encouraged to remove the activities declaration from their manifest files to reduce the possibility of duplicated intent filter declarations (no harm).
References
None
Testing
Manually tested