Update readme #617
Merged
Update readme #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Apr 27, 2021
Widcket
reviewed
Apr 27, 2021
Widcket
reviewed
Apr 27, 2021
| super.onDestroy(); | ||
| // Your own Activity code | ||
| lock.onDestroy(this); | ||
| lock = null; |
There was a problem hiding this comment.
Why is there no need to set the reference to null in the Kotlin version?
There was a problem hiding this comment.
Is not because of kotlin. When an android activity gets its onDestroy method called is because is going away for good. There's no need to set to null the references. The garbage collector will recycle the whole activity instance.
Widcket
requested changes
Apr 27, 2021
Co-authored-by: Rita Zerrizuela <[email protected]>
lbalmaceda
force-pushed
the
patch-readme
branch
from
60a8230 to
78c85ab
Compare
Co-authored-by: Steve Hobbs <[email protected]>
|
Comments addressed! |
Widcket
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the readme using kotlin snippets and removing instructions that no longer apply (e.g. OIDC mode).
The content is not final and might be updated in the following PRs.
References
See
SDK-2431