Revert "Fix tracing of server actions imported by client components (#78968) #35
+0
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ercel#78968)" This reverts commit af0473b. # Conflicts: # test/e2e/app-dir/actions/app-action.test.ts
|
✅ This pull request was succesfully scanned and it was determined that it does not contain any changes that present immediate security concerns. If you would still like for it to be reviewed by an expert from our reviewer community, you can submit it manually via the HackerOne PullRequest dashboard. ⏱️ Latest scan covered changes up to commit 2fbb6cc (latest) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems these additional fs operations/transforms on client components while tracing dependencies is causing a big perf hit which is not worth the edge case of catching fs dependencies in server actions from client components.
A workaround is available without our automatic tracing via
outputFileTracingIncludesso this reverts the tracing to alleviate the perf concern.We will be able to handle cases like this without the perf consequence with turbopack going forward.
This reverts commit af0473b.
Closes: vercel#81902
🔄 This is a mirror of upstream PR #82161