Folder upload_file method not working

[dparis]

I've got some code that looks like:

folder = client.folder_by_id(folder_id)
folder.upload_file(file_name, data)

And I'm getting an exception like Errno::ENAMETOOLONG: File name too long. It appears to be passing the data variable as the file name when creating a new file.

I've looked through the source for the upload_file method, and it looks okay, but I've also verified that file_name is just foo.csv so something's going awry.

Any ideas? Is the upload_file method available for use, or old dead code?

[dparis]

Anyone had a chance to look at this yet? I've got a deadline that's blocked by this bug. I don't mind debugging and potentially contributing a fix if necessary, just don't want to step on anyone's toes.

Thanks!

[cburnette]

along those lines, I know that attachments.me recently got acquired. Is anyone from the acquiring company watching this project at all? Chime in if you are!

thanks,
Chad

On Apr 22, 2014, at 3:49 PM, Dylan Paris notifications@github.com wrote:

Anyone had a chance to look at this yet? I've got a deadline that's blocked by this bug. I don't mind debugging and potentially contributing a fix if necessary, just don't want to step on anyone's toes.

Thanks!

—
Reply to this email directly or view it on GitHub.

[lkang]

I havent looked into the issue, too busy... I might be able to get to it this weekend, sorry guys

[dparis]

@lkang I debugged this for a bit. What's happening is that the data var I'm using is just a string. The initializer for UploadIO in the multipart-post gem expects the first parameter to be either a string to a filepath on the local filesystem, or else some kind of IO object which responds to the read method.

The call at https://github.com/attachmentsme/ruby-box/blob/master/lib/ruby-box/file.rb#L38 makes no attempt to check or cast the data variable passed in. If you pass any non-IO object to upload_content (and presumably update_content) it'll cause this problem.

This could be fixed in ruby-box by forcing any non-IO object passed to upload_content into a StringIO instance, using to_s on the data var to fill it. Otherwise, it could be avoided by updating the documentation and/or code comments to indicate that the data var needs to be an instance of an IO subclass.

I'm happy to make either fix and submit a PR. In the meantime, I'll work around this by casting to a StringIO before calling upload_content.

Cheers!