Skip to content

fix: Enable the same atSign to be used on both sides (client and server) of an AtRpc interaction #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 14, 2025

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Jun 13, 2025

- What I did
Main thing:

  • fix: Enable the same atSign to be used on both sides (client and server) of an AtRpc interaction

- How I did it

  • Added optional parameters isClient and isServer to AtRpc constructor. If isServer is set, then the AtRpc will listen to the requests regex. If isClient is set, then the AtRpc will listen to the responses regex.

- Other things of note:

  • fix: LocalSecondary.isEnrollmentAuthorizedForOperation now checks if the key in question is a local key, in which case the answer is always yes.
  • fix: AtClientImpl._putInternal now also checks if the key in question is a local key, in which case it does not require that the key have a namespace

- Chores etc

  • fix: changed severity of a log message in SyncServiceImpl from severe to warning, because sync failures can happen for a whole bunch of mundane reasons.
  • test: Moved test setup code in sync_service_test.dart into a setUp() method where it belongs. As a result, found a missing when in one of the tests, fixed that
  • docs: moved a @deprecated annotation to the place dart format prefers it to be
  • chore: tightened up logging in SyncServiceImpl

- How to verify it
Tests pass

@gkc gkc merged commit 1724a34 into trunk Jun 14, 2025
10 checks passed
@gkc gkc deleted the at-rpc-enable-same-atsign branch June 14, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants