fix: Enable the same atSign to be used on both sides (client and server) of an AtRpc interaction #1524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Main thing:
- How I did it
isClient
andisServer
to AtRpc constructor. IfisServer
is set, then the AtRpc will listen to the requests regex. IfisClient
is set, then the AtRpc will listen to the responses regex.- Other things of note:
LocalSecondary.isEnrollmentAuthorizedForOperation
now checks if the key in question is alocal
key, in which case the answer is always yes.AtClientImpl._putInternal
now also checks if the key in question is alocal
key, in which case it does not require that the key have a namespace- Chores etc
severe
towarning
, because sync failures can happen for a whole bunch of mundane reasons.when
in one of the tests, fixed that- How to verify it
Tests pass