Fix SEGFAULT in nif_lists_reverse
#1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblaszkow06
force-pushed
the
fix/lists-reverse-segfault
branch
from
f70738d to
ed6f7fc
Compare
bettio
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks for fixing this.
This fix is very important, so it should be merged into release-0.6.
Would you mind rebasing it to release-0.6 branch and adding a line to the changelog under the v0.6.6 / Fixes section? It would be nice something like "Fixed segfault in lists:reverse/1" or anything like that.
Also make sure to fixup everything in just one commit when adding this entry to the changelog.
A hardcoded `2` as roots count is invalid when nif is called as lists:reverse/1 Signed-off-by: Bartosz Błaszków <[email protected]>
bblaszkow06
force-pushed
the
fix/lists-reverse-segfault
branch
from
ed6f7fc to
2f0c35c
Compare
bettio
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hardcoded
2as roots count is invalid when the NIF is called aslists:reverse/1, possibly resulting in a SEGFAULT orFound unknown boxed type: Cerror during GCThese changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later