Add hardcoded sites to be intialised via user provided credential file #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akalia-atlassian
requested review from
bwieger-atlassian-com,
sdzh-atlassian,
cabella-dot,
marcomura and
pastelsky
as code owners
akalia-atlassian
force-pushed
the
feat/add-hardcoded-site-flow
branch
2 times, most recently
from
2fc4822 to
e7c308a
Compare
akalia-atlassian
force-pushed
the
refactor/auth-info-centralisation
branch
from
64ac971 to
652f927
Compare
akalia-atlassian
force-pushed
the
feat/add-hardcoded-site-flow
branch
from
e7c308a to
30618b2
Compare
pastelsky
reviewed
Apr 9, 2025
| @@ -1484,6 +1488,46 @@ | |||
| "default": true, | |||
| "description": "Shows the help explorer treeview", | |||
| "scope": "window" | |||
| }, | |||
| "atlascode.internal.hardcodedSite": { | |||
There was a problem hiding this comment.
nit: atlascode.internal.site ?
pastelsky
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
This PR touches a lot of files but ultimately it is a parallel flow for sites to be initialised initialised via settings
How Has This Been Tested?
In the earlier form, this has been tested fairly robustly on devsphere: but this is yet to be deployed / tested in its current avatar of being driven via settings.
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: