Skip to content

Add rimraf to integration-test devDeps #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

marcins
Copy link
Contributor

@marcins marcins commented Jul 1, 2025

Motivation

Can't run yarn add -D <anything> in packages/core/integration-tests because it complains that:

error An unexpected error occurred: "expected workspace package to exist for \"rimraf\"".

Changes

Seems the dependency is missing from the package.json, adding it in resolves the issue.

Checklist

  • Existing or new tests cover this change
  • There is a changeset for this change, or one is not required
  • Added documentation for any new features to the docs/ folder

[no-changeset]: Integration tests devdeps only

@marcins marcins requested a review from a team as a code owner July 1, 2025 04:44
Copy link

changeset-bot bot commented Jul 1, 2025

⚠️ No Changeset found

Latest commit: b9e1e75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

"_todo": "Remove exit: true when https://github.com/nodejs/node/pull/28788 is resolved",
"exit": true
"timeout": 50000
// "_todo": "Remove exit: true when https://github.com/nodejs/node/pull/28788 is resolved",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs/node#28788 is closed and potentially landed in 2019, based on this?
If not required, can we just delete it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I seem to have accidentally based this branch on a different branch where I'm testing whether we can remove this! I'll rebase on main..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the draft pull request for that: #663

But looking at the CI results from this PR, it looks like it's not going to work so easily..

@marcins marcins force-pushed the mszczepanski/fix-dependencies-in-integration-tests branch from 5cf0ef0 to b9e1e75 Compare July 1, 2025 05:54
@marcins marcins enabled auto-merge (squash) July 1, 2025 07:43
@marcins marcins disabled auto-merge July 1, 2025 22:57
@marcins marcins merged commit fbe52a5 into main Jul 1, 2025
29 of 31 checks passed
@marcins marcins deleted the mszczepanski/fix-dependencies-in-integration-tests branch July 1, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants