Skip to content

build: remove storybook #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions .storybook/main.js

This file was deleted.

74 changes: 0 additions & 74 deletions .storybook/preview.js

This file was deleted.

10 changes: 2 additions & 8 deletions babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,8 @@ module.exports = {
preventFullImport: true
}
}],
// Our build doesn't need the {loose: true} option, but if not included it wil
// show a lot of warnings on the storybook build.
["@babel/proposal-class-properties", {loose: true}],
["@babel/proposal-object-rest-spread", {loose: true}],
// Used only by storybook, but must be included to avoid build warnings/errors.
["@babel/plugin-proposal-private-methods", {loose: true}],
["@babel/plugin-proposal-private-property-in-object", {loose: true}],
["@babel/proposal-class-properties"],
["@babel/proposal-object-rest-spread"],
// Import helpers from @babel/runtime instead of duplicating them everywhere.
"@babel/plugin-transform-runtime",
// Better debug information for styled components.
Expand All @@ -75,6 +70,5 @@ module.exports = {
// Do not apply this babel config to node_modules.
// Shadow-CLJS also runs babel over node_modules and we don't want this
// configuration to apply to it.
// We still want it to be picked up by storybook though.
exclude: ["node_modules"]
}
12 changes: 1 addition & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"notebooks": "clojure -M:notebooks",
"notebooks:static": "clojure -X:notebooks-static",
"vercel:install": "./script/vercel-setup.sh && yarn && clojure -P",
"vercel:build": "yarn notebooks:static && yarn storybook:static && yarn client:web:static",
"vercel:build": "yarn notebooks:static && yarn client:web:static",
"// client scripts": "",
"dev": "yarn components && concurrently \"yarn components:watch\" \"yarn client:watch\"",
"client:watch": "shadow-cljs watch main renderer app",
Expand All @@ -34,8 +34,6 @@
"components:watch": "yarn components --watch",
"prod": "yarn components && shadow-cljs release main renderer app",
"dist": "electron-builder -p always",
"storybook": "start-storybook -p 6006",
"storybook:static": "build-storybook --output-dir vercel-static/storybook --quiet",
"// client e2e scripts": "",
"// add --config=playwright.electron.config.ts to any e2e script to use electron instead of web build": "",
"client:e2e": "xvfb-maybe playwright test",
Expand Down Expand Up @@ -107,7 +105,6 @@
"@dnd-kit/sortable": "^7.0.1",
"@emotion/react": "^11",
"@emotion/styled": "^11",
"@geometricpanda/storybook-addon-badges": "^0.0.4",
"@js-joda/core": "1.12.0",
"@js-joda/locale_en-us": "3.1.1",
"@js-joda/timezone": "2.2.0",
Expand Down Expand Up @@ -152,11 +149,6 @@
"@babel/preset-react": "^7.14.5",
"@babel/preset-typescript": "^7.15.0",
"@playwright/test": "^1.17.1",
"@storybook/addon-a11y": "^6.3.8",
"@storybook/addon-actions": "^6.3.8",
"@storybook/addon-essentials": "^6.3.8",
"@storybook/addon-links": "^6.3.8",
"@storybook/react": "^6.3.8",
"babel-loader": "^8.2.2",
"babel-plugin-module-resolver": "^4.1.0",
"babel-plugin-styled-components": "^1.13.2",
Expand All @@ -176,8 +168,6 @@
"shadow-cljs": "2.19.5",
"source-map-support": "^0.5.19",
"standard-version": "^9.3.1",
"storybook-dark-mode": "^1.0.8",
"tsconfig-paths-webpack-plugin": "^3.5.1",
"typescript": "^4.3.5",
"vercel": "^24.2.3",
"xvfb-maybe": "^0.2.1"
Expand Down
101 changes: 0 additions & 101 deletions src/js/components/AppToolbar/AppToolbar.stories.tsx

This file was deleted.

Loading