Skip to content

feat: Sidebar tasks #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Sep 5, 2022
Merged

feat: Sidebar tasks #2342

merged 33 commits into from
Sep 5, 2022

Conversation

shanberg
Copy link
Collaborator

@shanberg shanberg commented Sep 4, 2022 •
edited
Loading

  • Adds Widgets component for controlling stuff in left sidebar
  • Blocks in tasks as a widget

Prototype-only stuff:

  • Tasks should be checkable, openable, etc. Didn't get to this.
  • Filters/view controls on task widget
    • needs some thinking about what should be available and how that data should be managed

@vercel
Copy link

vercel bot commented Sep 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
athens ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 4:42PM (UTC)

@shanberg shanberg requested a review from jefftangx September 4, 2022 01:19
jefftangx
jefftangx reviewed Sep 5, 2022
View reviewed changes
src/js/components/Widget/Widget.tsx Outdated
Comment on lines 75 to 82
onClick={() => {
onToggle();
if (onClick) {
onClick();
}
}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to disclose?

src/cljs/athens/views/left_sidebar/subs.cljs Outdated
(let [user-page @(rf/subscribe [:presence/user-page])
props (-> (reactive/get-reactive-node-document [:node/title user-page])
:block/properties)
open? (-> (get props (shared/ns-str "/closed?"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open or closed?

@jefftangx jefftangx changed the title Sidebar tasks feat: Sidebar tasks Sep 5, 2022
@jefftangx jefftangx merged commit 8302846 into athensresearch:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefftangx jefftangx jefftangx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanberg @jefftangx