Skip to content

Add pyproject.toml for Custom Node Registry #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

haohaocreates
Copy link
Contributor

@haohaocreates haohaocreates commented May 22, 2024

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.

The main benefits are that authors can

  • publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
  • automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

  • Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
  • Write a short description.
  • Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish

Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

@haohaocreates
Copy link
Contributor Author

hey @aszc-dev, wanted to send a small nudge and ask if you had any questions!

@haohaocreates
Copy link
Contributor Author

@aszc-dev, wondering if there's any way we can support you on this PR!

@aszc-dev aszc-dev merged commit b8c263b into aszc-dev:main Jul 3, 2024
@aszc-dev
Copy link
Owner

aszc-dev commented Jul 3, 2024

Hello @haohaocreates,

Thank you for the registry and the initiative behind it.

I apologize for not being able to work on the issues and pull requests in this project for quite some time. I am planning to address this and will go through the remaining issues as soon as possible.

Everything looks good so far—the process went through successfully. Although I haven’t tried the installation yet, I can confirm that the repository is now visible in the registry.

Cheers,
Adrian

@haohaocreates
Copy link
Contributor Author

haohaocreates commented Jul 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants