Skip to content

feat: add server.title() and hasTitle() functions #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlexiusTatius
Copy link

Description

  • Added title() method to Server class to access server title attribute
  • Added hasTitle() helper method to check title existence
  • Updated ServerInterface with new method signatures
  • Added extra type in serverObject interface of v2
  • Added unit tests accordingly

Related issue(s)
Fixes #1075

- title(): returns the server title string or undefined
- hasTitle: returns boolean indicating if title exists
- added the unit tests for the respective functions
- tested the code by building, ensuring changes in esm, cjs
Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: 751dc3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sonarqubecloud bot commented Feb 1, 2025

@AlexiusTatius
Copy link
Author

@smoya Can you review this one too?

Copy link

@jonaslagoni jonaslagoni changed the title fix(server): added server.title() and hasTitle() functions fix: added server.title() and hasTitle() functions Mar 19, 2025
@jonaslagoni jonaslagoni changed the title fix: added server.title() and hasTitle() functions feat: add server.title() and hasTitle() functions Mar 19, 2025
@jonaslagoni
Copy link
Member

/rtm

@jonaslagoni
Copy link
Member

Looks like it needs a changeset: #1081 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing server.title() function
4 participants