Enable GKEStartPodOperatorAsync in integration tests
#721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanikumv
requested review from
bharanidharan14,
rajaths010494,
pankajastro and
pankajkoti
as code owners
phanikumv
changed the title
GKEStartPodOperatorAsync in integration tests
Codecov ReportBase: 98.48% // Head: 98.48% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 86 86
Lines 4622 4622
=======================================
Hits 4552 4552
Misses 70 70 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pankajastro
reviewed
Oct 21, 2022
| # GkeStartPod operator do not work on astro-cloud | ||
| # https://github.com/astronomer/astronomer-providers/issues/443 | ||
| # {"kubernetes_engine_dag": "example_google_kubernetes_engine"}, | ||
| {"kubernetes_engine_dag": "example_google_kubernetes_engine"}, |
There was a problem hiding this comment.
what was the fix @phanikumv or its working without any fixes?
There was a problem hiding this comment.
It works without any fixes(the OSS airflow fix worked for this)
pankajastro
approved these changes
Oct 21, 2022
rajaths010494
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #443