Capitalise module level constants #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
requested review from
phanikumv,
sunank200,
bharanidharan14,
rajaths010494 and
pankajastro
as code owners
kaxil
reviewed
Apr 14, 2022
docs/conf.py
Outdated
|
|
||
| # -- Project information ----------------------------------------------------- | ||
|
|
||
| project = "Astronomer Providers" | ||
| author = "Astronomer Inc." | ||
| PROJECT = "Astronomer Providers" |
There was a problem hiding this comment.
We can't do the others though as they are needed by Sphinx.
We only can do that are used internally, like REPO_DIR. Feel free to make it internal if you want to by adding _ i.e. _REPO_DIR
kaxil
reviewed
Apr 14, 2022
docs/conf.py
Outdated
| @@ -34,7 +34,7 @@ | |||
| # Add any Sphinx extension module names here, as strings. They can be | |||
| # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom | |||
| # ones. | |||
| extensions = [ | |||
| _EXTENSIONS = [ | |||
There was a problem hiding this comment.
Suggested change
| _EXTENSIONS = [ | |
| extensions = [ |
There was a problem hiding this comment.
This is also used by Sphinx for extensions
There was a problem hiding this comment.
kaxil
approved these changes
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 45 45
Lines 2541 2541
=======================================
Hits 2448 2448
Misses 93 93 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should Captailaize module level constants not used by Sphinx as a convention