Skip to content

Add flake8-bugbear in pre-commit hooks #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Add flake8-bugbear in pre-commit hooks #213

merged 1 commit into from
Apr 9, 2022

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Apr 9, 2022

This commit adds yet another flake8 plugin - https://github.com/PyCQA/flake8-bugbear . This plugin for flake8 helps finding likely bugs and design problems in code. Contains warnings that don't belong in pyflakes and pycodestyle:

This commit adds yet another flake8 plugin - https://github.com/PyCQA/flake8-bugbear . This plugin for flake8 helps finding likely bugs and design problems in code. Contains warnings that don't belong in pyflakes and pycodestyle:
@kaxil kaxil force-pushed the add-bugbear-flake8 branch from 8aa7d3f to b1c9da9 Compare April 9, 2022 13:33
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #213 (b1c9da9) into main (620397d) will increase coverage by 0.05%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   96.29%   96.34%   +0.05%     
==========================================
  Files          45       45              
  Lines        2534     2542       +8     
==========================================
+ Hits         2440     2449       +9     
+ Misses         94       93       -1     
Impacted Files Coverage Δ
astronomer/providers/amazon/aws/hooks/s3.py 99.17% <50.00%> (-0.83%) ⬇️
astronomer/providers/amazon/aws/triggers/s3.py 100.00% <100.00%> (ø)
astronomer/providers/apache/livy/hooks/livy.py 98.87% <100.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620397d...b1c9da9. Read the comment docs.

@kaxil kaxil merged commit c43091a into main Apr 9, 2022
@kaxil kaxil deleted the add-bugbear-flake8 branch April 9, 2022 14:14
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! 👍 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants