Revert "feat(kubernetes): check state before deferring KubernetesPodOperatorAsync (#1104)" #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peratorAsync (#1104)" This reverts commit 89ccc7e. PR #1104 adds logic to poke for Pod status before putting the status check on deferral. However, it is observed that our DAG fails always when we go on checking the status.phase on pods as Pod.status is None before the pod gets scheduled on a None. So, in most scenarios it does not make sense to check for the pod status immediately to verify that the pod has completed it's desired execution and hence, we revert this poke in case of Kubernetes Pod operator.
pankajkoti
requested review from
phanikumv,
pankajastro,
Lee-W,
sunank200 and
utkarsharma2
as code owners
phanikumv
approved these changes
Jun 22, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 98.59% 98.58% -0.01%
==========================================
Files 90 90
Lines 5395 5389 -6
==========================================
- Hits 5319 5313 -6
Misses 76 76
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 89ccc7e.
PR #1104 adds logic to poke for Pod status before putting the status
check on deferral. However, it is observed that our DAG fails always
when we go on checking the status.phase on pods as Pod.status is None
before the pod gets scheduled on a node. So, in most scenarios it does
not make sense to check for the pod status immediately to verify that the
pod has completed its desired execution and hence, we revert this poke
in case of Kubernetes Pod operator.
closes: #1208