-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6484 use upstream registry 3.x #943
Conversation
@danielhoherd pls dont merge this change without any signoff this has a breaking change |
@pgvishnuram if this PR has a problem, we need a ticket describing our unique needs that are not being met by the upstream source code. |
2024/02/05 13:53:18 traces export: Post "https://localhost:4318/v1/traces": dial tcp [::1]:4318: connect: connection refused to resolve this set below env vars
|
https://github.com/distribution/distribution/blob/main/docs/content/about/notifications.md the core problem here seems notification endpoint not being initialized properly
with new registry
the untrusted key error is from code block https://github.com/distribution/distribution/blob/main/registry/auth/token/token.go#L183-L189 |
This is a huge long standing change for us - after 2 years of v2 usage we are finally resynced with upstream |
@pgvishnuram we've been using 2.x since the beginning, 2020-01-06!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Details
Instead of building registry, copy it from upstream. This PR solves the following CVEs:
The only CVEs that remain are:
Related Issues
Checklist