Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6484 use upstream registry 3.x #943

Merged
merged 17 commits into from
Apr 10, 2025
Merged

Conversation

@danielhoherd danielhoherd requested review from a team as code owners February 13, 2025 01:09
@pgvishnuram
Copy link
Contributor

pgvishnuram commented Feb 17, 2025

@danielhoherd pls dont merge this change without any signoff this has a breaking change

@Shubham-astro Shubham-astro marked this pull request as draft February 17, 2025 10:06
@danielhoherd
Copy link
Member Author

@pgvishnuram if this PR has a problem, we need a ticket describing our unique needs that are not being met by the upstream source code.

@danielhoherd danielhoherd changed the title 6484 use upstream registry 2.8.3 6484 use upstream registry 3.x Mar 14, 2025
@pgvishnuram
Copy link
Contributor

2024/02/05 13:53:18 traces export: Post "https://localhost:4318/v1/traces": dial tcp [::1]:4318: connect: connection refused

to resolve this set below env vars

OTEL_TRACES_EXPORTER=none

@pgvishnuram
Copy link
Contributor

pgvishnuram commented Apr 7, 2025

time="2025-04-07T14:28:31.236647995Z" level=error msg="retryingsink: error writing event, retrying" error="httpSink{}: error posting: Post \"\": unsupported protocol scheme \"\"" event="{cb07ad17-2120-44c2-a451-34823aa589e1 2025-04-07 11:28:02.848522344 +0000 UTC m=+180.285628091 push {{application/octet-stream sha256:bc5050d10d9a4450f51f11e34cd88853d4ce30eb4017b58c4a1609b8d2ae1897 5829 [] map[] [] <nil> } 5829 bright-corona-4831/airflow  https://xxxxxxv2/bright-corona-4831/airflow/blobs/sha256:bc5050d10d9a4450f51f11e34cd88853d4ce30eb4017b58c4a1609b8d2ae1897  []} {b0bf515d-b95d-44de-9fc9-bce5e40de407 10.10.5.89 xxxxxxx PUT docker/27.5.1 go/

https://github.com/distribution/distribution/blob/main/docs/content/about/notifications.md

the core problem here seems notification endpoint not being initialized properly

time="2025-04-08T05:08:09.773769171Z" level=info msg="configuring endpoint houston (http://xxxxx-houston:8871/v1/registry/events), timeout=30s, headers=map[Authorization:[XOEnGZ6ybz7VF9XOmw7itDLupxYKSieD]]" go.version=go1.15.15 instance.id=2e8bbfc2-4e6c-4eaa-a9e3-8fd902911ddc service=registry version=v2.7.0-333-g26bdf12d

with new registry

kubectl logs -f deploy/astronomer-registry        
time="2025-04-08T05:16:04.337122675Z" level=info msg="configuring endpoint  (), timeout=0s, headers=map[Authorization:[uHzgdV25z9fYvtMX303WEIkxFj6dJMre]]" go.version=go1.23.7 instance.id=17501583-f01a-40e1-8e34-e887e56a290d service=registry version=3.0.0

the untrusted key error is from code block

https://github.com/distribution/distribution/blob/main/registry/auth/token/token.go#L183-L189

@danielhoherd danielhoherd marked this pull request as ready for review April 9, 2025 19:05
@pgvishnuram
Copy link
Contributor

This is a huge long standing change for us - after 2 years of v2 usage we are finally resynced with upstream

@danielhoherd
Copy link
Member Author

danielhoherd commented Apr 9, 2025

This is a huge long standing change for us - after 2 years of v2 usage we are finally resynced with upstream

@pgvishnuram we've been using 2.x since the beginning, 2020-01-06!

$ git show $(git log --format="%H" -- registry/ | tail -n 1):registry/Dockerfile | grep FROM
FROM registry:2.7.1

Copy link
Contributor

@himabindu07 himabindu07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgvishnuram pgvishnuram merged commit a6c94eb into main Apr 10, 2025
7 checks passed
@pgvishnuram pgvishnuram deleted the 6484-use-upstream-registry-2-8-3 branch April 10, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants