disable Force color over no color

[Aditya-PS-05]

closes #8173

[zanieb]

Won't this always match since the default is "auto" at the clap-level?

[Aditya-PS-05]

Yupp, But I thought if --color is passed explicitly, we can use the value of args.color directly.

[Aditya-PS-05]

Also, when I tested the expected result was coming for all three separate cases. Means for FORCE_COLOR and --color and with sub arguments.

[Aditya-PS-05]

Won't this always match since the default is "auto" at the clap-level?

Done purposely, as when the user does not anything (neither the environment variables nor the --color), then I wanted the auto property. As If --color is given, it doesn't matter the value, we can always use them.

[samypr100]

Unless I'm missing something, I believe this changes standard behavior since env var should still take priority over cli when honoring the order of no color > force color | force cli color > auto

For example, if you have NO_COLOR set and pass --color always as well, NO_COLOR should take precedence.

[zanieb]

if you have NO_COLOR set and pass --color always as well, NO_COLOR should take precedence.

Should it? Honestly not sure.

[samypr100]

if you have NO_COLOR set and pass --color always as well, NO_COLOR should take precedence.

Should it? Honestly not sure.

Fair, I was considering CI scenarios when I said this. Wouldn't this be a breaking if changed?

[charliermarsh]

The docs (https://no-color.org/) at least state that "per-instance command-line arguments should override the NO_COLOR environment variable".

[samypr100]

The docs (https://no-color.org/) at least state that "per-instance command-line arguments should override the NO_COLOR environment variable".

Does the same apply for FORCE_COLOR? Or CLICOLOR_FORCE?

[samypr100]

The docs (https://no-color.org/) at least state that "per-instance command-line arguments should override the NO_COLOR environment variable".

Does the same apply for FORCE_COLOR? Or CLICOLOR_FORCE?

Sounds like it does at least for CLICOLOR_FORCE, https://bixense.com/clicolors/
FORCE_COLOR doesn't say.

I've likely been using it wrong 😆

To me, its a bit vague since the relationship between NO_COLOR and FORCE_COLOR and CLICOLOR_FORCE in this scenario is not well defined in any of the standards from what I can see.

Sounds like uv should follow this then?

1. Explicit CLI --color never / --color always takes precedence over the env vars.
2. Env vars then kick-in, NO_COLOR > FORCE_COLOR | CLICOLOR_FORCE
3. Auto Detection

What about an explicit --color auto? It's not clear which one would apply in the presence of the env vars being set.

[charliermarsh]

Yeah, agree with this @samypr100:

• Explicit CLI --color never / --color always takes precedence over the env vars.
• Env vars then kick-in, NO_COLOR > FORCE_COLOR | CLICOLOR_FORCE
• Auto Detection

I think --color=auto should also override the env vars (https://bixense.com/clicolors/ shows an example of that, arguably).

[charliermarsh]

@Aditya-PS-05 - Do you plan to pursue the follow-up changes mentioned here?

[Aditya-PS-05]

Yeah, agree with this @samypr100:

* Explicit CLI --color never / --color always takes precedence over the env vars.

* Env vars then kick-in, NO_COLOR > FORCE_COLOR | CLICOLOR_FORCE

* Auto Detection

I think --color=auto should also override the env vars (https://bixense.com/clicolors/ shows an example of that, arguably).

@charliermarsh
I am making this change following your instructions.

[Aditya-PS-05]

All the required changes are done in the pr #8215