Skip to content

uv python install: Detect hard-float support #7725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

kakkoyun
Copy link
Contributor

@kakkoyun kakkoyun commented Sep 26, 2024

Signed-off-by: Kemal Akkoyun [email protected]

Summary

This pull request fixes #6873 by implementing
a mechanism to detect whether the ARM architecture supports the VFP (Vector Floating Point) hardware,
which is critical for selecting the appropriate libc variant.

The detection is based on reading the flags from /proc/cpuinfo.
Specifically, if the vfp flag is present, the system will use the gnueabihf (hard-float ABI) variant;
if not, it will default to gnueabi (soft-float ABI).

For additional context, see the Debian documentation on the ARM Hard Float Port.

Test Plan

  • Verify that the correct libc variant is selected on an ARM system with and without VFP support.

@kakkoyun kakkoyun requested review from konstin and zanieb September 26, 2024 19:35
Signed-off-by: Kemal Akkoyun <[email protected]>
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: Kemal Akkoyun <[email protected]>
@zanieb zanieb marked this pull request as ready for review October 1, 2024 18:54
@zanieb zanieb added bug Something isn't working uv python Related to the uv python interface labels Oct 1, 2024
@kakkoyun
Copy link
Contributor Author

kakkoyun commented Oct 2, 2024

Quick update: I'm still trying to set up some old RPIs to test this.

@zanieb
Copy link
Member

zanieb commented Oct 29, 2024

Replacing with #8498

@zanieb zanieb closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working uv python Related to the uv python interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv python install 3.12 is not working on armv7 libc is identify as gnu instead of gnueabihf
4 participants