Add basic uv sync and uv lock commands
#3436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/sync
branch
from
14621c7 to
1b533d6
Compare
charliermarsh
commented
May 7, 2024
| let link_mode = LinkMode::default(); | ||
| let no_binary = NoBinary::default(); | ||
| let no_build = NoBuild::default(); | ||
| let setup_py = SetupPyStrategy::default(); |
There was a problem hiding this comment.
We could DRY this up but not sure if it's worth it.
charliermarsh
commented
May 7, 2024
|
|
||
| /// Run a command. | ||
| #[allow(clippy::unnecessary_wraps, clippy::too_many_arguments)] | ||
| pub(crate) async fn run( |
There was a problem hiding this comment.
This is just the existing run.rs, but moved into the workspace module, and the resolve and install commands were pulled into standalone methods.
charliermarsh
force-pushed
the
charlie/sync
branch
6 times, most recently
from
7a73411 to
5da8977
Compare
konstin
approved these changes
May 8, 2024
BurntSushi
approved these changes
May 8, 2024
charliermarsh
force-pushed
the
charlie/sync
branch
from
5da8977 to
f8e9aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These aren't intended for production use; instead, I'm just trying to frame out the overall data flows and code-sharing for these commands. We now have
uv sync(sync the environment to match the lockfile, without refreshing or resolving) anduv lock(generate the lockfile). Both require a virtual environment to exist (something we should change).uv sync,uv run, anduv lockall share code for the underlying subroutines (resolution and installation), so the commands themselves are relatively small (~100 lines) and mostly consist of reading arguments and such.uv lockanduv syncdon't actually really work yet, because we have no way to include the project itself in the lockfile (that's a TODO in the lockfile implementation).Closes #3432.